Conversation
AkarinServer
commented
Jan 22, 2026
- merge pending branches (icons + order history)
- bump version to 0.4.0+6
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a645d66760
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| try { | ||
| await _db.insertOrder(order); |
There was a problem hiding this comment.
Save order only after payment confirmation
The order is inserted into the database before the payment flow completes. Because PaymentScreen only calls onPaymentConfirmed after the admin PIN succeeds, any user who backs out of the screen or fails the PIN will still have an order recorded, inflating order history and revenue metrics while the cart remains uncleared. Consider deferring insertOrder until the confirmation callback or explicitly persisting it as a pending order.
Useful? React with 👍 / 👎.